Add capability information to the metamodel #1591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaSolOs
commented
Nov 30, 2024
| @@ -25,6 +25,7 @@ export namespace ConfigurationRequest { | |||
| export const type = new ProtocolRequestType<ConfigurationParams, LSPAny[], never, void, void>(method); | |||
| export type HandlerSignature = RequestHandler<ConfigurationParams, LSPAny[], void>; | |||
| export type MiddlewareSignature = (params: ConfigurationParams, token: CancellationToken, next: HandlerSignature) => HandlerResult<LSPAny[], void>; | |||
| export const capabilities: { client: 'workspace.configuration'; server: 'workspace' } = { client: 'workspace.configuration', server: 'workspace' }; | |||
There was a problem hiding this comment.
@dbaeumer The spec doesn't mention a server capability for the workspace/configuration request so I'm unsure about this. Since this is requested by the server it seems like there's no server capability needed here?
MariaSolOs
commented
Nov 30, 2024
| @@ -59,6 +59,7 @@ export namespace CallHierarchyPrepareRequest { | |||
| export const messageDirection: MessageDirection = MessageDirection.clientToServer; | |||
| export const type = new ProtocolRequestType<CallHierarchyPrepareParams, CallHierarchyItem[] | null, never, void, CallHierarchyRegistrationOptions>(method); | |||
| export type HandlerSignature = RequestHandler<CallHierarchyPrepareParams, CallHierarchyItem[] | null, void>; | |||
| export const capabilities: { client: 'textDocument.callHierarchy'; server: 'callHierarchyProvider' } = { client: 'textDocument.callHierarchy', server: 'callHierarchyProvider' }; | |||
There was a problem hiding this comment.
@dbaeumer Do you think we should add capability information for requests like callHierarchy/incomingCalls that don't define their own capabilities and instead depend on whether the server supports other methods (in this case textDocument/prepareCallHierarchy)?
MariaSolOs
force-pushed
the
capabilities
branch
3 times, most recently
from
c10685b
to
24151f6
Compare
MariaSolOs
force-pushed
the
capabilities
branch
from
24151f6
to
9dce9a9
Compare
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes microsoft/language-server-protocol#2059.