Client never sets partialResultToken and only sets workDoneToken during initialize
#528
Comments
|
@david-driscoll VS Code has currently no support for work done and partial result progress. Although they are in the spec (mainly because other clients were asking for them) it will take a while until VS Code will support them. Is there a special feature you want to see supported first? |
|
Nope! Usually these things land in VSCode around the same time as they do in the spec, as I was implementing them in the C# LSP library I wanted to validate that they were working as expected. I was just want to make sure I wasn't missing something. 😄 Thanks! |
|
@dbaeumer if we need to ping vscode people to add this new feature (incrementally update UI/results for Workspace Symbols or Find All References) who should we talk to? |
|
@heejaechang you need to open an issue against VS Code (see also microsoft/vscode#20010) |
|
opened microsoft/vscode#105870 |
It seems there was a confusing with workDoneProgressParams and workDoneProgressOptions. [workDoneProgressParams](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workDoneProgressParams) is the type used for the token in methods and notifications, it is the token itself, so it has type str | int. This type is correct, this was to explain context. [workDoneProgressOptions](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workDoneProgressOptions) is the type used for registration, it is used to indicate if work done progress are supported, so it is a boolean. This type was wrong. It seems as of today vscode does include workDoneProgress in requests: - microsoft/vscode-languageserver-node#528 (comment) - microsoft/vscode#105870
It seems there was a confusing with WorkDoneProgressParams and WorkDoneProgressOptions. [WorkDoneProgressParams](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workDoneProgressParams) is the type used for the token in methods and notifications, it is the token itself, so it has type str | int. This type is correct, this was to explain context. [WorkDoneProgressOptions](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workDoneProgressOptions) is the type used for registration, it is used to indicate if work done progress are supported, so it is a boolean. This type was wrong. It seems as of today vscode does include workDoneProgress in requests: - microsoft/vscode-languageserver-node#528 (comment) - microsoft/vscode#105870
dbaeumer
added
feature-request
Currently
workDoneTokenonly gets set by the client duringinitialize. And no place is thepartialResultTokenassigned as far as I can tell.I'm not sure if it's implemented or not (leaning on not).
The text was updated successfully, but these errors were encountered: