We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContentEncoder, ContentDecoder, ContentTypeEncoder and ContentTypeDecoder should be exported from jsonrpc, I think.
ContentEncoder
ContentDecoder
ContentTypeEncoder
ContentTypeDecoder
MessageReaderOptions uses ContentDecoder and ContentTypeDecoder:
MessageReaderOptions
vscode-languageserver-node/jsonrpc/src/common/messageReader.ts
Lines 112 to 118 in 07b9d29
similar for MessageWriterOptions:
MessageWriterOptions
vscode-languageserver-node/jsonrpc/src/common/messageWriter.ts
Lines 95 to 99 in 07b9d29
MessageReaderOptions and MessageWriterOptions are public:
vscode-languageserver-node/jsonrpc/src/common/api.ts
Lines 52 to 55 in f2ff7d5
Right now I have to do
import type {ContentTypeDecoderOptions} from 'vscode-jsonrpc/node'; import type {ContentTypeDecoder} from 'vscode-jsonrpc/lib/common/encoding';
The text was updated successfully, but these errors were encountered:
Fixes Missing exported types from jsonrpc encoding #1292
ca025f7
Fixes Missing exported types from jsonrpc encoding #1292 (#1316)
3dab7ac
thanks!
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
ContentEncoder
,ContentDecoder
,ContentTypeEncoder
andContentTypeDecoder
should be exported from jsonrpc, I think.Details
MessageReaderOptions
usesContentDecoder
andContentTypeDecoder
:vscode-languageserver-node/jsonrpc/src/common/messageReader.ts
Lines 112 to 118 in 07b9d29
similar for
MessageWriterOptions
:vscode-languageserver-node/jsonrpc/src/common/messageWriter.ts
Lines 95 to 99 in 07b9d29
MessageReaderOptions
andMessageWriterOptions
are public:vscode-languageserver-node/jsonrpc/src/common/api.ts
Lines 52 to 55 in f2ff7d5
Right now I have to do
The text was updated successfully, but these errors were encountered: