Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell cmd should load executables from venv folder #9090

Merged
merged 7 commits into from
Feb 22, 2022
Merged

Conversation

DonJayamanne
Copy link
Contributor

Fixes #9089

@DonJayamanne DonJayamanne requested a review from a team as a code owner February 21, 2022 22:27
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #9090 (e55d79e) into main (69e7bf7) will decrease coverage by 0%.
The diff coverage is 89%.

@@          Coverage Diff          @@
##            main   #9090   +/-   ##
=====================================
- Coverage     71%     71%   -1%     
=====================================
  Files        382     382           
  Lines      24681   24692   +11     
  Branches    4001    4004    +3     
=====================================
- Hits       17574   17565    -9     
+ Misses      5517    5516    -1     
- Partials    1590    1611   +21     
Impacted Files Coverage Δ
src/client/common/variables/types.ts 100% <ø> (ø)
...atascience/kernel-launcher/kernelEnvVarsService.ts 75% <66%> (-1%) ⬇️
...atascience/jupyter/kernels/jupyterKernelService.ts 79% <80%> (-1%) ⬇️
src/client/common/variables/environment.ts 96% <100%> (+<1%) ⬆️
...ience/variablesView/variableViewMessageListener.ts 77% <0%> (-23%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 67% <0%> (-11%) ⬇️
...ent/datascience/jupyter/kernels/kernelExecution.ts 67% <0%> (-6%) ⬇️
.../client/datascience/debugLocationTrackerFactory.ts 92% <0%> (-4%) ⬇️
src/client/common/application/webviews/webview.ts 73% <0%> (-2%) ⬇️
...ience/kernel-launcher/localKernelSpecFinderBase.ts 76% <0%> (-2%) ⬇️
... and 17 more

@DonJayamanne DonJayamanne merged commit 8408aab into main Feb 22, 2022
@DonJayamanne DonJayamanne deleted the issue9089 branch February 22, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell commands such as !pip !python !where python do not point to the right executable
3 participants