Perf notebook start kernel #8334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8334 +/- ##
======================================
- Coverage 72% 71% -1%
======================================
Files 373 374 +1
Lines 23373 23544 +171
Branches 3589 3622 +33
======================================
+ Hits 16829 16896 +67
- Misses 5086 5186 +100
- Partials 1458 1462 +4
|
DonJayamanne
commented
Nov 23, 2021
| (await this.fs.localFileExists(preferredKernelFromCache.interpreter.path)) | ||
| ) { | ||
| traceInfo(`Freferred kernel connection found in cache ${preferredKernelFromCache.id}`); | ||
| return preferredKernelFromCache; |
There was a problem hiding this comment.
No need to search through all the kernels if we have a cached kernel that matches exactly with what's in the notebook metadata.
DonJayamanne
commented
Nov 23, 2021
| const uniqueItems = new Map<string, LocalKernelConnectionMetadata>(); | ||
| items.forEach((item) => uniqueItems.set(item.id, item)); | ||
| kernels.forEach((item) => uniqueItems.set(item.id, item)); | ||
| await this.globalState.update(LocalKernelSpecConnectionsCacheKey, Array.from(uniqueItems.values())); |
There was a problem hiding this comment.
Cache all local kernel connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Par of #7849