Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelspec argv containing non traditional args for {connection_file} #7212

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

DonJayamanne
Copy link
Contributor

For #7203

@codecov-commenter
Copy link

Codecov Report

Merging #7212 (e4c08d1) into main (86e8e95) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #7212    +/-   ##
======================================
  Coverage     64%     64%            
======================================
  Files        359     360     +1     
  Lines      22656   22572    -84     
  Branches    3416    3403    -13     
======================================
+ Hits       14641   14656    +15     
+ Misses      6717    6613   -104     
- Partials    1298    1303     +5     
Impacted Files Coverage Δ
src/client/datascience/jupyter/kernels/helpers.ts 67% <100%> (ø)
...lient/datascience/kernel-launcher/kernelProcess.ts 70% <100%> (+<1%) ⬆️
...e/interactive-ipynb/nativeEditorCommandListener.ts 44% <0%> (-5%) ⬇️
src/client/datascience/notebook/notebookEditor.ts 36% <0%> (-4%) ⬇️
...ent/datascience/notebook/notebookEditorProvider.ts 82% <0%> (-2%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 67% <0%> (-2%) ⬇️
...lient/datascience/variablesView/notebookWatcher.ts 83% <0%> (-1%) ⬇️
src/client/datascience/jupyter/kernelVariables.ts 44% <0%> (-1%) ⬇️
src/client/datascience/types.ts 100% <0%> (ø)
...eractive-window/nativeInteractiveWindowProvider.ts 41% <0%> (ø)
... and 9 more

@DonJayamanne DonJayamanne changed the title Support kernelspec argv containing non traditional args for {connection_file} kernelspec argv containing non traditional args for {connection_file} Aug 23, 2021
@DonJayamanne DonJayamanne merged commit 4dd37f7 into main Aug 23, 2021
@DonJayamanne DonJayamanne deleted the issue7203 branch August 23, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants