Revert work around for not being able to install ipykernel #6952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontainers" This reverts commit 9aa2ae6.
DonJayamanne
changed the title
rchiodo
reviewed
Aug 2, 2021
| @@ -247,15 +246,6 @@ export class PythonInstaller implements IPythonInstaller { | |||
| this.interpreterPackages.trackPackages(resource); | |||
| } | |||
| let action: 'installed' | 'failed' | 'disabled' | 'ignored' = 'installed'; | |||
| if (env.remoteName && reInstallAndUpdate) { | |||
| // Temporary work around for https://github.com/microsoft/vscode-jupyter/issues/6896 | |||
| traceWarning( | |||
There was a problem hiding this comment.
Is the bug still active? Wondering how we make sure to fix this for real before next release.
There was a problem hiding this comment.
The bug is active & moved to Python repo, microsoft/vscode-python#16851
We cannot add a work around at our end.
There was a problem hiding this comment.
Reverting as the work around doesn't fix it (i thought it did, but was wrong).
rchiodo
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).