Refactor preferred controller for interactive #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jul 12, 2021
| @@ -238,19 +236,8 @@ export class NativeInteractiveWindowProvider implements IInteractiveWindowProvid | |||
| } | |||
|
|
|||
| private async getControllerForInteractiveWindow(): Promise<string | undefined> { | |||
| // Fetch the active interpreter and use the matching controller | |||
| const api = await this.pythonApi.getApi(); | |||
There was a problem hiding this comment.
The logic for what's the preferred should be in the manager (that's where it is today for native notebooks).
DonJayamanne
commented
Jul 12, 2021
| public async getInteractiveController(): Promise<VSCodeNotebookController | undefined> { | ||
| // Fetch the active interpreter and use the matching controller | ||
| const api = await this.pythonApi.getApi(); | ||
| const activeInterpreter = await api.getActiveInterpreter(); |
There was a problem hiding this comment.
This change also makes it easier for #5861
Else we have to change a few places, when ideally we should have the controllers created & return from a single place.
DonJayamanne
requested review from
DavidKutu,
IanMatthewHuff,
joyceerhl and
rchiodo
joyceerhl
reviewed
Jul 12, 2021
rchiodo
approved these changes
Jul 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #6642 +/- ##
=======================================
- Coverage 64% 63% -2%
=======================================
Files 352 409 +57
Lines 24542 28249 +3707
Branches 3750 4195 +445
=======================================
+ Hits 15930 17944 +2014
- Misses 7194 8712 +1518
- Partials 1418 1593 +175
|
Co-authored-by: Joyce Er <[email protected]>
joyceerhl
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.