fix: restart frame not working #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the paused state wasn't set and we weren't in the function after hitting "restart frame". Both the previous adapter[1] and the Chrome devtools themselves[2] just discard the response of restart frame and immediately stepInto(). Doing the same here appears to work well and fixes #142. 1. https://github.com/microsoft/vscode-chrome-debug-core/blob/d4bd01568b2bff1109bb75d80d487b5fbbc8427e/src/chrome/chromeDebugAdapter.ts#L1603-L1605 2. https://github.com/ChromeDevTools/devtools-frontend/blob/c96ccd99f0e299d9cce23a8667eb1d35e057f7e0/front_end/sdk/DebuggerModel.js#L1382-L1385
dgozman
reviewed
Dec 5, 2019
| @@ -26,19 +26,6 @@ describe('breakpoints', () => { | |||
| p.assertLog(); | |||
| }); | |||
|
|
|||
| itIntegrates('script', async ({ r }) => { | |||
There was a problem hiding this comment.
It seems like this removal is accidental?
connor4312
force-pushed
the
fix/restart-frame
branch
from
4aa4e55 to
2b5068a
Compare
roblourens
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the paused state wasn't set and we weren't in the function
after hitting "restart frame". Both the previous adapter[1] and the
Chrome devtools themselves[2] just discard the response of restart frame
and immediately stepInto(). Doing the same here appears to work well
and fixes #142.