feat: implement step in targets #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Jun 14, 2022
| /** | ||
| * Gets a "step into" target at the given offset in the line of code. | ||
| */ | ||
| export function getStepTargetInfo(line: string, offset: number) { |
There was a problem hiding this comment.
Is this still going to return breakpoint locations that are not step into targets? I'm not sure
roblourens
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft/vscode#123879
It uses possible breakpoint locations to extra and display possible step ranges. It tries to parse the source line to get the appropriate label and range to return to VS Code, which works pretty well in my testing.
Step into works similarly to what core does in "run to line" -- it sets a breakpoint on the desired location, resumes the debugger (skipping all pauses until the breakpoint is hit), then removes the breakpoint and steps in.