Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy fix #461

Merged
merged 5 commits into from
Jun 4, 2020
Merged

Proxy fix #461

merged 5 commits into from
Jun 4, 2020

Conversation

badsyntax
Copy link
Collaborator

Refs #397

  • Disable http proxy in the gRPC client
  • Remove race condition workaround if gRPC server is slow to start
  • Proxy tests

@badsyntax
Copy link
Collaborator Author

Tests successfully failing here: https://github.com/badsyntax/vscode-gradle/runs/737513604?check_suite_focus=true (odd that tests only fail in windows. they fail locally for me on macos, perhaps it's a github actions VM thing)

And tests successfully passing here, showing the http proxy fix in grpc-js works: https://github.com/badsyntax/vscode-gradle/actions/runs/124539042

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@badsyntax
Copy link
Collaborator Author

Tests are now failing and succeeding as expected. LGTM.

@badsyntax badsyntax merged commit 6fb00e0 into master Jun 4, 2020
@badsyntax badsyntax deleted the proxy-fix branch June 4, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant