Wait for gRPC server to start before connecting client #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badsyntax
force-pushed
the
wait-for-server
branch
from
4095518 to
c1024bf
Compare
badsyntax
force-pushed
the
wait-for-server
branch
from
c1024bf to
bd59199
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
LGTM. Tests are consistently passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #397
As the gGRPC client should only try connect once the server is started, we now wait for the socket to be open before attempting to connect.
The extension will wait a maximum of 2 minutes for the socket to be open on the specified port. This should be more than enough time for most machines.