Don't update vscode when tests are running

.github/workflows/build-and-test.yml

@@ -45,7 +45,7 @@ jobs:
       matrix:
         node-version: [12.16.2]
         java-version: ['8', '11']
-        os: [ubuntu-latest, windows-latest] # unable to test on macos-latest, see https://github.com/microsoft/vscode/issues/98080
+        os: [ubuntu-latest, windows-latest, macos-latest]
     steps:
       - uses: actions/checkout@v1
       - name: Use Node ${{ matrix.node-version }}

extension/src/test/runTests.ts

@@ -1,18 +1,20 @@
 /* eslint-disable sonarjs/no-duplicate-string */
 import * as path from 'path';
 
-import { runTests } from 'vscode-test';
+import { runTests, downloadAndUnzipVSCode } from 'vscode-test';
 
 const extensionDevelopmentPath = path.resolve(__dirname, '../../');
+const VSCODE_VERSION = '1.45.0';
 
-async function runTestsWithGradle(): Promise<void> {
+async function runTestsWithGradle(vscodeExecutablePath: string): Promise<void> {
   const fixtures = [
     'gradle-groovy-default-build-file',
     'gradle-kotlin-default-build-file',
     'gradle-groovy-custom-build-file',
   ];
   for (const fixture of fixtures) {
     await runTests({
+      vscodeExecutablePath,
       extensionDevelopmentPath,
       extensionTestsPath: path.resolve(__dirname, 'gradle'),
       launchArgs: [
@@ -27,8 +29,9 @@ async function runTestsWithGradle(): Promise<void> {
   }
 }
 
-async function runTestsWithoutGradle(): Promise<void> {
-  await runTests({
+function runTestsWithoutGradle(vscodeExecutablePath: string): Promise<number> {
+  return runTests({
+    vscodeExecutablePath,
     extensionDevelopmentPath,
     extensionTestsPath: path.resolve(__dirname, 'no-gradle'),
     launchArgs: [
@@ -41,8 +44,9 @@ async function runTestsWithoutGradle(): Promise<void> {
   });
 }
 
-async function runTestsWithMultiRoot(): Promise<void> {
-  await runTests({
+function runTestsWithMultiRoot(vscodeExecutablePath: string): Promise<number> {
+  return runTests({
+    vscodeExecutablePath,
     extensionDevelopmentPath,
     extensionTestsPath: path.resolve(__dirname, 'multi-root'),
     launchArgs: [
@@ -59,8 +63,11 @@ async function runTestsWithMultiRoot(): Promise<void> {
   });
 }
 
-async function runTestsWithMultiProject(): Promise<void> {
-  await runTests({
+async function runTestsWithMultiProject(
+  vscodeExecutablePath: string
+): Promise<number> {
+  return runTests({
+    vscodeExecutablePath,
     extensionDevelopmentPath,
     extensionTestsPath: path.resolve(__dirname, 'multi-project'),
     launchArgs: [
@@ -75,14 +82,15 @@ async function runTestsWithMultiProject(): Promise<void> {
 }
 
 async function main(): Promise<void> {
-  try {
-    await runTestsWithGradle();
-    await runTestsWithMultiRoot();
-    await runTestsWithMultiProject();
-    await runTestsWithoutGradle();
-  } catch (err) {
-    process.exit(1);
-  }
+  const vscodeExecutablePath = await downloadAndUnzipVSCode(VSCODE_VERSION);
+
+  runTestsWithGradle(vscodeExecutablePath)
+    .then(() => runTestsWithMultiRoot(vscodeExecutablePath))
+    .then(() => runTestsWithMultiProject(vscodeExecutablePath))
+    .then(() => runTestsWithoutGradle(vscodeExecutablePath))
+    .catch((err) => {
+      console.error('Error running tests:', err.message);
+    });
 }
 
 main();

extension/test-fixtures/gradle-groovy-custom-build-file/.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "update.mode": "none"
+}

extension/test-fixtures/gradle-groovy-default-build-file/.gitignore

@@ -3,6 +3,3 @@
 
 # Ignore Gradle build output directory
 build
-
-# Ignore .vscode settings
-.vscode

extension/test-fixtures/gradle-groovy-default-build-file/.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "update.mode": "none"
+}

extension/test-fixtures/gradle-kotlin-default-build-file/.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "update.mode": "none"
+}

extension/test-fixtures/multi-project/.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "update.mode": "none"
+}