This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Activate extension when workspace contains go files #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -66,6 +66,7 @@ | |||
| "vscode": "^1.30.0" | |||
| }, | |||
| "activationEvents": [ | |||
| "workspaceContains:**/.go", | |||
There was a problem hiding this comment.
Shouldn't this be:
Suggested change
| "workspaceContains:**/.go", | |
| "workspaceContains:**/*.go", |
Otherwise it will only activate, if it finds a literal .go file.
I wanted to open a PR myself and this happened to me during testing, when omitting the asterisk in the globbing pattern.
There was a problem hiding this comment.
🤦♂️oops, thanks @ToothlessGear
ramya-rao-a
approved these changes
Nov 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2821