This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Attempt to fix the debugger jumping to gopark #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Dec 31, 2018
src/debugAdapter/goDebug.ts
Outdated
| this.handleReenterDebug('breakpoint'); | ||
| }); | ||
| this.sendResponse(response); | ||
| verbose('ContinueResponse'); |
There was a problem hiding this comment.
The verbose call for logging should move as well
|
@segevfiner I am using Regardless, I believe this is a change we should make anyway. The response should be sent by the adapter only after the call to delve completes. |
Darn... Guess we'll have to keep digging... |
ramya-rao-a
approved these changes
Dec 31, 2018
segevfiner
added a commit
to segevfiner/vscode-go
that referenced
this pull request
Dec 31, 2018
This reverts commit 456fdab.
ramya-rao-a
pushed a commit
that referenced
this pull request
Jan 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec you are first supposed to acknowledge the command and only than send the stopped event. Changing this seems to have fixed the jumping to
gopark/proc.gofor me. Please test that this works.Debugging is still really slow, but that's a different issue, VS Code is simply requesting, and receiving, way too much information from delve on each step.
See: Debug Adapter Protocol Specification - Next Request.
Possible fix for #2133