Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Diposing decorators before applying new ones for code coverage. #2068

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

SteelPhase
Copy link
Contributor

I've updated #2047 with the changes requested

Following the suggestions described on issue #2045

Similar to the function updateCodeCoverageDecorators the applyCodeCoverage function now disposes of any existing decorators before applying new ones.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another place where setDecorators is called right after disposeDecorators in this file. You can remove the disposeDecorators from that location as well

@ramya-rao-a
Copy link
Contributor

Also, I see that this is your first contribution to vscode-go. Welcome & Thanks!
I hope that you have registered both for the Microsoft Hacktoberfest and the one from Digitalocean

Happy Coding!

@SteelPhase
Copy link
Contributor Author

@ramya-rao-a I've rebased this branch against master, and I think I changed what you were pointing out.

@ramya-rao-a
Copy link
Contributor

Thanks!

@ramya-rao-a ramya-rao-a merged commit c96594b into microsoft:master Nov 1, 2018
@SteelPhase SteelPhase deleted the issue-2045 branch November 1, 2018 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants