Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Too many -d's. #642

Closed
OneOfOne opened this issue Nov 23, 2016 · 2 comments
Closed

Too many -d's. #642

OneOfOne opened this issue Nov 23, 2016 · 2 comments

Comments

@OneOfOne
Copy link
Contributor

So I was looking in the debug console trying to figure out why Go To def wasn't working, I couldn't really figure it out but I noticed this:

/home/oneofone/code/go/bin/goreturns -d -d -d -d -d -d -d -d [filename]
# then few errors later we got up to
/home/oneofone/code/go/bin/goreturns -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d -d
@ramya-rao-a
Copy link
Contributor

Nice catch. https://github.com/Microsoft/vscode-go/blob/master/src/goFormat.ts#L33 is where we add the -d to formatFlags variable. That variable is scoped to the function, I wonder why it persists value from previous runs.

@OneOfOne OneOfOne mentioned this issue Nov 23, 2016
Merged
@OneOfOne
Copy link
Contributor Author

@ramya-rao-a it's because vscode.workspace.getConfiguration('go')['formatFlags'] returns a reference and you keep updating it.

ramya-rao-a pushed a commit that referenced this issue Nov 23, 2016
@OneOfOne @ramya-rao-a
Fixes #642 Only add -d once to formatflags (#644)
88dfe84
mattetti added a commit to mattetti/vscode-go that referenced this issue Jan 11, 2017
@mattetti
Merge branch 'master' of github.com:mattetti/vscode-go
461d4bb 
* 'master' of github.com:mattetti/vscode-go: (128 commits)
  Add telemetry support for the Go extension
  Add dlv path to error msg when dlv not found
  Fixes microsoft#465 outline offset problem in No-English language (microsoft#699)
  fix coverage display when editor changes to undefined (microsoft#693)
  Add support for reading http.proxy setting (microsoft#639)
  Fixing flaky unit tests
  Refactor for corner cases
  Reduce noise in console log due to errors from hover
  Changelog for next update 0.6.51
  Remove space after brackets in snippet as per microsoft#628
  Fixes microsoft#647 Strip version from autocompleted pkgs from gopkg.in (microsoft#659)
  Fixes microsoft#647 Support vendor pkgs from root of GOPATH/src (microsoft#660)
  Fixes microsoft#640 Use spawn to handle big data from gocode (microsoft#661)
  Fixed wrong workspace when one gopath is the substring of another. (microsoft#658)
  Fix "gotests" when generates test for current function for type methods (microsoft#657)
  Add benchmark function snippet (microsoft#648)
  Fix "Go to Definition" when running Go HEAD (microsoft#655)
  Fixes microsoft#642 Only add -d once to formatflags (microsoft#644)
  Updating Changelog and package.json for 0.6.50 update
  Log errors to console
  ...
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OneOfOne @ramya-rao-a