Disallow import internal root package (#1681)

* Disallow internal package on root * Fix the regex for detecting internal package * Disallow to use internal package located on root
microsoft · Jun 4, 2018 · 1d48333 · 1d48333
1 parent 5bc4ce4
commit 1d48333
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/goPackages.ts b/src/goPackages.ts
@@ -277,6 +277,10 @@ export function getNonVendorPackages(folderPath: string): Promise<string[]> {
 // see: https://golang.org/doc/go1.4#internalpackages
 // see: https://golang.org/s/go14internal
 function isAllowToImportPackage(toDirPath: string, currentWorkspace: string, pkgPath: string) {
+	if (pkgPath.startsWith('internal/')) {
+		return false;
+	}
+
 	let internalPkgFound = pkgPath.match(/\/internal\/|\/internal$/);
 	if (internalPkgFound) {
 		let rootProjectForInternalPkg = path.join(currentWorkspace, pkgPath.substr(0, internalPkgFound.index));