Avoid duplicate function parameter body on function suggest snippets (#…

…1696) * Avoid duplicate function parameter body on function suggest snippets Avoid adding snippet for function suggest when cursor is followed by (). Fixes #1655 * Review feedback. Simplify logic * Review feedback. Simplify logic
microsoft · Jun 3, 2018 · 10acfbd · 10acfbd
1 parent eb1c86d
commit 10acfbd
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/goSuggest.ts b/src/goSuggest.ts
@@ -199,7 +199,11 @@ export class GoCompletionItemProvider implements vscode.CompletionItemProvider {
 										paramSnippets.push('${' + (i + 1) + ':' + param + '}');
 									}
 								}
-								item.insertText = new vscode.SnippetString(suggest.name + '(' + paramSnippets.join(', ') + ')');
+								// Avoid adding snippet for function suggest when cursor is followed by ()
+								// i.e: met() -> method()()
+								if (lineText.substr(position.character, 2) !== '()') {
+									item.insertText = new vscode.SnippetString(suggest.name + '(' + paramSnippets.join(', ') + ')');
+								}
 							}
 							if (config['useCodeSnippetsOnFunctionSuggest'] && suggest.class === 'type' && suggest.type.startsWith('func(')) {
 								let { params, returnType } = getParametersAndReturnType(suggest.type.substring(4));