Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Docker Compose Usage in Documentation #7290

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dreglad
Copy link

@dreglad dreglad commented May 15, 2024

This PR complements #6924 / #692. In addition to update syntax/naming conventions, this takes a step further by enhancing Docker Compose usage throughout the documentation and examples.

Summary of Changes

  1. Removal of Deprecated version Field:

    • Removed the top-level version field from examples as it is deprecated and was used inaccurately in most cases.
  2. Simplification by Removing Unnecessary links:

    • The links field at the service level is unnecessary and has no effect in the examples. Removing it simplifies the examples.
  3. Update to Volume Mounts:

    • Removed the :cached suffix from volume mounts, which is specific to Mac and is now unnecessary. This keeps the examples platform-agnostic and simpler.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dreglad dreglad marked this pull request as ready for review October 15, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants