Add envFile to compose task spec
#4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghogen
approved these changes
Nov 30, 2021
|
@bwateratmsft, this is well written. #sign-off but we'll wait on the next release in January |
raghavthind2005
approved these changes
Dec 3, 2021
faisal8048003
approved these changes
Dec 12, 2021
import-brain
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft/vscode-docker#3339 I was going to remove
envFilesfrom the docs but I discovered it was never added in the first place. So, adding the newenvFileoption that will replace it.NOTE: Please hold off on merging until our 1.19 release, tentatively 17 Jan 22.Ready to merge!