Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update VS Code overview page #4964

Merged
merged 2 commits into from
Nov 17, 2021
Merged

update VS Code overview page #4964

merged 2 commits into from
Nov 17, 2021

Conversation

ucheNkadiCode
Copy link
Contributor

This PR updates the current state of the VS Code Docker overview page to include newer gifs and content about our latest features

@ucheNkadiCode
Copy link
Contributor Author

I would like to wait on sign off from @bwateratmsft

Thank you!

@bwateratmsft
Copy link
Contributor

Looks good to me, thanks @ucheNkadiCode!

Fixes microsoft/vscode-docker/issues/3224

@ghogen
Copy link
Collaborator

ghogen commented Nov 16, 2021

@ucheNkadiCode This is great, thanks! One thing - for the hover-support.png file, the tooltip text is cut off, which might be distracting for people trying to read it. Would it be possible to recreate the screenshot showing the full tooltip text?

@ucheNkadiCode
Copy link
Contributor Author

@ucheNkadiCode Uche Nkadi FTE This is great, thanks! One thing - for the hover-support.png file, the tooltip text is cut off, which might be distracting for people trying to read it. Would it be possible to recreate the screenshot showing the full tooltip text?

hey @ghogen, I'm personally not seeing how the tool tip is cut off? That is all of the text for the image tooltip

@import-brain
Copy link
Contributor

@ucheNkadiCode Uche Nkadi FTE This is great, thanks! One thing - for the hover-support.png file, the tooltip text is cut off, which might be distracting for people trying to read it. Would it be possible to recreate the screenshot showing the full tooltip text?

hey @ghogen, I'm personally not seeing how the tool tip is cut off? That is all of the text for the image tooltip

Yeah, tool tip looks fine to me.

@gregvanl
Copy link

gregvanl commented Nov 17, 2021

I think @ghogen may have been looking at the image preview, which has a horizontal scroll bar to be able to see the full width of the image.
The image looks fine to me as well in the doc preview.

@ghogen
Copy link
Collaborator

ghogen commented Nov 17, 2021

Sorry, yes I see it now. Approved.

@gregvanl gregvanl merged commit 4bac6f3 into microsoft:main Nov 17, 2021
@gregvanl
Copy link

@ucheNkadiCode Does this PR fix #4932 and we can close that issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants