Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extension guide with updates, corrections for GitHub Codespaces #4450

Merged
merged 5 commits into from
Apr 6, 2021

Conversation

Chuxel
Copy link
Member

@Chuxel Chuxel commented Apr 1, 2021

This PR updates the extension guide for VS Code Remote - * and the devcontainer.json reference to be in line with current support now that the unified containers implementation is in place.

Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates! Left just a few minor questions, but nothing major.

api/advanced-topics/remote-extensions.md Show resolved Hide resolved
docs/remote/containers.md Show resolved Hide resolved
docs/remote/devcontainerjson-reference.md Outdated Show resolved Hide resolved
docs/remote/devcontainerjson-reference.md Outdated Show resolved Hide resolved
docs/remote/devcontainerjson-reference.md Outdated Show resolved Hide resolved
@gregvanl gregvanl added the remote label Apr 2, 2021
@Chuxel
Copy link
Member Author

Chuxel commented Apr 5, 2021

Ok @gregvanl - Think it's ready for a once over and merge.

@gregvanl
Copy link

gregvanl commented Apr 5, 2021

@Chuxel Roger. I wasn't sure whether we were waiting for Christof. I'll have a look and publish today

@gregvanl gregvanl merged commit b80ead1 into main Apr 6, 2021
@gregvanl gregvanl deleted the clantz/misc-corrections branch March 24, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants