Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user cancel showing messages #745

Merged
merged 3 commits into from
Jan 16, 2019
Merged

Fix user cancel showing messages #745

merged 3 commits into from
Jan 16, 2019

Conversation

StephenWeatherford
Copy link
Contributor

Fixes #718

@StephenWeatherford StephenWeatherford requested a review from a team as a code owner January 16, 2019 03:36
@StephenWeatherford
Copy link
Contributor Author

Another option would be to set a flag inside cancel errors. I doubt this will make much of a difference in performance, though.

@ejizba ejizba mentioned this pull request Jan 16, 2019
Merged
@StephenWeatherford StephenWeatherford merged commit d1d6601 into master Jan 16, 2019
@StephenWeatherford StephenWeatherford deleted the saw/usercancellederror branch March 12, 2019 00:04
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejizba ejizba ejizba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenWeatherford @ejizba