Add support for certificates #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
reviewed
Nov 16, 2018
ejizba
approved these changes
Nov 17, 2018
ejizba
reviewed
Nov 19, 2018
| @@ -15,7 +15,7 @@ gulp.task('test', ['install-azure-account'], (cb) => { | |||
| const env = process.env; | |||
| env.DEBUGTELEMETRY = 1; | |||
| env.CODE_TESTS_WORKSPACE = './test/test.code-workspace'; | |||
| env.MOCHA_reporter = 'mocha-junit-reporter'; | |||
| //env.MOCHA_reporter = 'mocha-junit-reporter'; | |||
There was a problem hiding this comment.
If you're going to comment this out then you have to set MOCHA_reporter somewhere else otherwise the CI builds will never fail for tests
There was a problem hiding this comment.
Yeah, working on that. The current situation makes it difficult to troubleshoot.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483