Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding auto-complete support for compose v2.1 files #50

Merged
merged 2 commits into from
Dec 21, 2016
Merged

Conversation

lostintangent
Copy link
Member

@lostintangent lostintangent commented Dec 20, 2016

This addresses #36 by enabling auto-complete support for the six new properties that were added to the compose v2.1 format (that was released with Docker Compose v1.9), and ensuring that they are only suggested for files that are specifically using that version.

Note: I also deleted the vsix from the top-level of the repo since we didn't need to version control it.

CC @chrisdias

Copy link
Member

@chrisdias chrisdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the .vsix?

@lostintangent
Copy link
Member Author

@chrisdias I believe this PR is already removing the .vsix file. Should I revert this change? I wasn't sure whether this file was needed so I just decided to delete it.

@chrisdias
Copy link
Member

chrisdias commented Dec 20, 2016 via email

@lostintangent
Copy link
Member Author

@chrisdias Cool :) Are you good with this PR then?

@chrisdias chrisdias merged commit 4f94eff into master Dec 21, 2016
@ejizba ejizba deleted the compose_2_1 branch July 4, 2019 00:11
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants