Mention admin accounts for ACR in readme. #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -144,7 +144,8 @@ Before we can accept your pull request you will need to sign a **Contribution Li | |||
|
|
|||
| Make sure you are signed in to the Docker Hub or Azure container registry from the docker CLI via `docker login` (using your username, not your e-mail address). | |||
|
|
|||
| If you are using an Azure container registry, you will need to get the username and password from Azure by right-clicking on the Azure container registry in the extension and selecting "Browse in the Azure Portal", then selecting the "Access Keys" tab. | |||
| If you are using an Azure container registry, you will need to ensure admin user is enabled. To do this, right-click on the Azure container registry in the extension and select "Browse in the Azure Portal" - select the "Access Keys" tab in the portal. You will then see the username and password from Azure. | |||
There was a problem hiding this comment.
If admin user is not enabled, they will not see it in the extension anyway, so I think this is confusing to put here.
There was a problem hiding this comment.
As a note, just submitted PR #341 which addresses this, Admin enabled is no longer necessary for listing container registries at all, only for launching an image into app services and this is only because app services does not support non admin enabled container registries.
There was a problem hiding this comment.
@PrashanthCorp can this PR be closed based on above comments? Been open for a few months now...
|
Closing due to lack of response and above comments |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.