estebanreyl/Unified Azure Utilities #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 24, 2018 15:16
Update dev to match Microsoft/vscode-docker/master
* Added Azure Credentials Manager Singleton * Added getResourceManagementClient
estebanreyl
changed the title
utils/azureUtilityManager.ts
Outdated
| //GETTERS | ||
| public getAccount(): AzureAccount { | ||
| if (this.azureAccount) { return this.azureAccount; } | ||
| throw new Error(('Azure account is not present, you may have forgotten to call setAccount')); |
There was a problem hiding this comment.
nit: double parentheses
utils/azureUtilityManager.ts
Outdated
|
|
||
| //CHECKS | ||
| //Provides a unified check for login that should be called once before using the rest of the singletons capabilities | ||
| public async isLoggedIn(): Promise<boolean> { |
There was a problem hiding this comment.
Let's keep the concept count the same by naming it waitForLogin like AzureAccount.waitForLogin
utils/azureUtilityManager.ts
Outdated
| return this.getAccount().filters.map<SubscriptionModels.Subscription>(filter => { | ||
| return { | ||
| id: filter.subscription.id, | ||
| session: filter.session, |
There was a problem hiding this comment.
Are you planning on using session (which isn't in SubscriptionModels.Subscription)?
There was a problem hiding this comment.
Not really. GetFilteredSubscriptionList is a function that was already in the program, I just provided a centralized location for it. If its furthermore not in SubscriptionModels.Subscription I think we can safely remove it, thanks!
|
Sorry for the delay, see minor comments. |
|
No worries, thanks for the comments! I've updated accordingly |
StephenWeatherford
approved these changes
Aug 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a singleton client for managing Azure credentials/resources internally. This helps facilitate production of further azure connectivity and extends on many of the existing methods adding optimized async support where possible. The client includes the following features: