Upgrade Dockerfile language server to 0.7.2 #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small update prevents two cases of infinite loops from being thrown in a textDocument/semanticTokens/full request. Signed-off-by: Remy Suen <[email protected]>
karolz-ms
approved these changes
Oct 21, 2021
|
Thank you, Remy 🤗 |
Thanks for reviewing the change, @karolz-ms. Have a good day! :) |
|
Thanks so much @rcjsuen! We always appreciate your help 😁 |
No problem, @ucheNkadiCode. 👍 I know that this particular bug is annoying given the constant spamming of error messages so I wanted to get a fix out as soon as possible. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small update prevents two cases of infinite loops from being thrown in a
textDocument/semanticTokens/fullrequest. One of the two cases is the one reported in #3268.Open these two files as Dockerfiles and you should see the exception error pop up. Do not save or format the file as the bug is contingent on the second line not having any whitespace in the front.
FROM $image\ abcYou can also test with the Dockerfile described in #3268 (comment). Opening that file should not cause any problems either.