Remove start page in favor of walkthrough #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
commented
Sep 30, 2021
| @@ -2838,7 +2827,6 @@ | |||
| { | |||
| "id": "dockerStart", | |||
| "title": "%vscode-docker.walkthrough.dockerStart.title%", | |||
| "when": "never", | |||
There was a problem hiding this comment.
This line makes the walkthrough no-longer-an-experiment.
| @@ -2997,7 +2985,6 @@ | |||
| "@types/xml2js": "^0.4.8", | |||
| "@typescript-eslint/eslint-plugin": "^4.28.4", | |||
| "@typescript-eslint/parser": "^4.28.4", | |||
| "@vscode/codicons": "^0.0.22", | |||
There was a problem hiding this comment.
Codicons package is no longer used.
bwateratmsft
commented
Sep 30, 2021
| }, | ||
| { | ||
| "command": "vscode-docker.help.openWalkthrough", | ||
| "when": "never" |
There was a problem hiding this comment.
There's already a VSCode command to open the walkthrough so I don't see a need for this to show in the palette.
There was a problem hiding this comment.
The only reason we need this command defined at all is because the tree view command can't provide an argument to workbench.action.openWalkthrough.
bwateratmsft
changed the title
philliphoff
approved these changes
Oct 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3235. This removes the old start page since the walkthrough is clearly more successful and less intrusive.
I looked into replacing the tree view node for "Open Start Page" with one that would launch straight to the walkthrough, but it doesn't seem possible unfortunately.I figured it out!