Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to see dangling images in the explorer #2967

Merged
merged 6 commits into from
Jun 1, 2021

Conversation

jnsjunior
Copy link
Contributor

Reference Issues/PRs

Explorer: dangling images #2547

Changes

Implement an option to see dangling images in the explorer

image

image

@jnsjunior jnsjunior requested a review from a team as a code owner May 25, 2021 02:14
@ghost
Copy link

ghost commented May 25, 2021

CLA assistant check
All CLA requirements met.

@jnsjunior
Copy link
Contributor Author

There is one more adjust, new commit.
When i remove dangling image, the fullTag is used to remove the image, or the RepoDigests when it's end with ':none'.
Some cases the digest end with '@none' and this cause an error (bellow).

image

image

image

So, i propose check digest end and use the image ID when digest end with '@none'

image

@karolz-ms
Copy link
Contributor

@jnsjunior thank you for your contribution, much appreciated!

I think adding the ability to show dangling images makes a lot of sense; I am just wondering if a configuration setting is the best way to enable it. An alternative could be to add an enable/disable button to the Images pane in the Docker explorer (next to the existing "Prune" command, see screenshot below). This would be more accessible/discoverable... 🤔

image

Also @BigMorty @philliphoff please share your thoughts.

@jnsjunior
Copy link
Contributor Author

@karolz-ms yes i agree with your opinion.
i will try to implement this function using a enable/disable button on the panel.

@jnsjunior
Copy link
Contributor Author

Here is,

image

Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple minor suggestions.

We are super grateful for this change and for following up on the suggestion to make it a command! 🤗

package.nls.json Outdated Show resolved Hide resolved
src/tree/images/ImageTreeItem.ts Outdated Show resolved Hide resolved
@karolz-ms karolz-ms requested a review from philliphoff May 27, 2021 16:08
@karolz-ms
Copy link
Contributor

@philliphoff please share your thoughts as well if you can

package.json Outdated Show resolved Hide resolved
@karolz-ms karolz-ms merged commit a19ea5c into microsoft:main Jun 1, 2021
@karolz-ms
Copy link
Contributor

@jnsjunior thanks again for your contribution, much appreciated, and sorry for not merging sooner, we had a holiday here in the US yesterday ☺️

@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants