Change quoting on Windows hosts #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
commented
Mar 3, 2021
| @@ -5,7 +5,7 @@ | |||
| "requires": true, | |||
| "packages": { | |||
| "": { | |||
| "version": "1.10.5-alpha", | |||
| "version": "1.11.0", | |||
There was a problem hiding this comment.
I have no clue why npm update didn't bump this last time. 🤷♂️
bwateratmsft
commented
Mar 3, 2021
| @@ -144,7 +144,7 @@ function parseWindowsDirectoryItems(input: string, parentPath: string): Director | |||
| export async function listLinuxContainerDirectory(executor: DockerContainerExecutor, parentPath: string): Promise<DirectoryItem[]> { | |||
| const commandProvider: DockerExecCommandProvider = shell => { | |||
| return shell === 'windows' | |||
| ? ['/bin/sh', '-c', `"ls -la \"${parentPath}\""`] | |||
| ? ['/bin/sh', '-c', `"ls -la '${parentPath}'"`] | |||
There was a problem hiding this comment.
This matches the quoting that is used for the stat command.
philliphoff
approved these changes
Mar 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2739. I tried out the command line that it comes up with--both the
statandlscommands--and each works on both cmd and PowerShell. (Also, of course, I tried it out in the UI)In theory this should have no effect on Unix but I also validated on my Macbook just to be sure.