Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python code to override entrypoint #2732

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Remove Python code to override entrypoint #2732

merged 1 commit into from
Feb 25, 2021

Conversation

bwateratmsft
Copy link
Collaborator

Fixes #2725

@bwateratmsft bwateratmsft requested a review from a team as a code owner February 24, 2021 17:52
karolz-ms
karolz-ms approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should not set entrypoint like this when it is not specified... esp. since python is by no means an obvious default for Python workloads.

@bwateratmsft bwateratmsft merged commit b4d734e into main Feb 25, 2021
@bwateratmsft bwateratmsft deleted the bmw/entrypoint branch February 25, 2021 18:22
@bwateratmsft
Copy link
Collaborator Author

This may need to get reverted.

@bwateratmsft bwateratmsft mentioned this pull request Mar 2, 2021
Merged
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karolz-ms karolz-ms karolz-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entrypoint for docker-run task
2 participants
@bwateratmsft @karolz-ms