Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extension kind from package.json #2422

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Remove extension kind from package.json #2422

merged 1 commit into from
Oct 20, 2020

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Oct 20, 2020

Fixes #2356, but even better than we expected. IMO the user experience here is the best possible.

When the user first connects to the remote session, the Extensions page directs them to install Docker in the remote (which is what we want almost everybody to do):
image

Once they install it in the remote, it starts working right away:
image
image
(Notice the name of the image--makes it easy to tell that it's getting this data from Docker on my SSH target)

HOWEVER! Here's the good part that I did not expect. The user can forcibly override it to use UI mode, using the setting:

    "remote.extensionKind": {
        "ms-azuretools.vscode-docker": [
            "ui"
        ]
    }

When they apply this setting and reload VSCode, Docker becomes active in UI mode:
image
image
(These are images on my local machine)

@bwateratmsft bwateratmsft requested a review from a team as a code owner October 20, 2020 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing UI mode for remoting
2 participants