Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 0.0.14 of the language server #233

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Mar 8, 2018

It's been two months since version 0.0.13! There are of course both bug fixes and features but the biggest change is probably the internal refactoring that happened inside the npm module. Assuming everything went fine, you shouldn't be able to notice the difference. :) This release includes the fix for #218.

As always, please use the following Dockerfile to test out the latest changes!

#escape=`
# it should be possible to Ctrl+Click node and jump to its site on Docker Hub
FROM node
# it should be possible to Ctrl+Click microsoft/dotnet and jump to its site on Docker Hub
FROM microsoft/dotnet
# hover over ARG, it should state that it was added in Docker 1.9
ARG x=y
RUN `
# there should be code actions to remove these empty lines
            
            
            `
            
       ls

# 5s-10ms is an invalid duration, it should be flagged as an error
HEALTHCHECK --interval=5s-10ms CMD ls
# 5s.1ms is a valid duration, it should not be flagged as an error
HEALTHCHECK --timeout=5s.1ms CMD ls

# the last argument of a multiargument ADD/COPY must be a directory, z/ or z\
ADD x y z
COPY x y z
# ok
ADD x y z/
COPY x y z/
# ok
ADD x y z\
COPY x y z\

# these digests and tags are all invalid, should be flagged as errors
FROM alpine@
FROM alpine@sha25:x
FROM alpine:
FROM alpine:^
FROM alpine:a66^

# hover over STOPSIGNAL, it says it was added in 1.12 when it should be 1.9
STOPSIGNAL 9
ARG FTP_PROXY
# invoke Intellisense here
# you shouldn't get two capitalized $FTP_PROXY entries
RUN $FTP

FROM scratch
ENV xyz=y
FROM alpine
# invoke Intellisense here, $xyz should not be suggested as
# it's a variable from another build stage
RUN echo $x

# $ is an invalid kill code and should be an error
STOPSIGNAL $

# all these instructions are in a different build stage and
# should not be flagged as duplicates as errors
# this fixes issue 218
# https://github.com/Microsoft/vscode-docker/issues/218
FROM alpine
HEALTHCHECK CMD ls
ENTRYPOINT ls
CMD ls
FROM alpine
ENTRYPOINT pwd
CMD pwd
HEALTHCHECK CMD pwd

# trigger parameter hints with Ctrl+Shift+Space after the S in AS
# hit the down key to look at the 2/3 and 3/3 suggestions
# and you will see that the underlined parameter
# is not the AS and is incorrect
FROM node AS

This release includes changes to how workspace/configuration requests
are handled as they have become a part of the official LSP
specification.

textDocument/documentLink requests are now handled by creating links
for image names that open to hub.docker.com.

Signed-off-by: Remy Suen <[email protected]>
@chrisdias chrisdias merged commit c7e7da6 into microsoft:master Mar 20, 2018
@rcjsuen rcjsuen deleted the lsp-0.0.14 branch March 20, 2018 05:06
chrisdias added a commit that referenced this pull request Mar 31, 2018
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants