Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to deploy from ACR / Docker Hub to ACI #2265

Merged
merged 12 commits into from
Sep 8, 2020
Merged

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Aug 31, 2020

Fixes #1718. Also implements a few of the now-available APIs in the new Docker Serve client.

@bwateratmsft bwateratmsft requested a review from karolz-ms August 31, 2020 15:44
@bwateratmsft bwateratmsft requested a review from a team as a code owner August 31, 2020 15:44
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few clarifying questions

@bwateratmsft bwateratmsft merged commit e53eb2d into master Sep 8, 2020
@bwateratmsft bwateratmsft deleted the bmw/deployaci branch September 8, 2020 16:46
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
* Implement ACI deployment

* Container action warning
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to deploy an image in ACR (or other registry?) to Azure Container Instances (ACI)
2 participants