Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade language server to 0.1.0 #2146

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Jul 11, 2020

This update provides the following changes:

image

Please use the Dockerfile to test the new changes and bug fixes.

FROM alpine AS base
# this should not be a link anymore, issue 2043
# instead, clicking on it now should jump to the stage definition above
# https://github.com/microsoft/vscode-docker/issues/2043
FROM base
# this will now have a strikeout decoration to indicate that it is deprecated
# not sure if this is only for VS Code 1.47 or not though...?
MAINTAINER user

# the A should be coloured like X and Y
RUN --mount=X=Y,A echo

FROM scratch
# this should create an error because the ENV has no arguments
ENV \
    # comment

The following Dockerfiles have very specific whitespace characters to reproduce the error in question. Simply copy and paste the content into a Dockerfile and and open the Output panel and select the Dockerfile Language Server to verify that there are no errors being logged. Do not save the file as the formatter will change the integrity of the file.

# issue 2055
# https://github.com/microsoft/vscode-docker/issues/2055
FROM alpine
ENV \
    # common variables:
    ENV1=something
FROM alpine
COPY a b \
\ 
/dir
# there are two problems here
# 1 - the semantic tokens is buggy and there is an infinite loop here
# 2 - the validation is wrong, the red squiggles should be over the whole argument
# which spans across all 3 lines instead of simply the `/di\` in the beginning
FROM alpine
COPY a b /di\
\
\r

This update improves the Dockerfile parser, navigation actions, and
provides a visual affordance to the deprecated MAINTAINER instruction.

Signed-off-by: Remy Suen <[email protected]>
@rcjsuen
Copy link
Contributor Author

rcjsuen commented Jul 11, 2020

Looks like the macOS build failed but I have no idea why.

@bwateratmsft
Copy link
Collaborator

The macOS pipeline is really temperamental for whatever reason...

@microsoft microsoft deleted a comment from azure-pipelines bot Jul 12, 2020
Copy link
Collaborator

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome as usual, thanks @rcjsuen!

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Jul 13, 2020

@bwateratmsft Thanks for reviewing. See you again in a month or two I guess...? :P

Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
This update improves the Dockerfile parser, navigation actions, and
provides a visual affordance to the deprecated MAINTAINER instruction.

Signed-off-by: Remy Suen <[email protected]>
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants