Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating an ACI context from palette / contexts view #2135

Merged
merged 11 commits into from
Jul 8, 2020

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Jul 7, 2020

Fixes (mostly) #2114. Adds support for creating an ACI context in the command palette and contexts view. The command will not show up unless we can positively confirm that the new CLI is present, according to the following rules--

  1. If another ACI context already exists, OR
  2. If the output of docker serve --help starts with "Start an api server"

TODO: add screenshots

@bwateratmsft bwateratmsft requested a review from karolz-ms July 7, 2020 17:20
@bwateratmsft bwateratmsft requested a review from a team as a code owner July 7, 2020 17:20
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

src/docker/ContextManager.ts Show resolved Hide resolved
@bwateratmsft bwateratmsft merged commit 5f32d26 into master Jul 8, 2020
@bwateratmsft bwateratmsft deleted the bmw/acicreate branch July 8, 2020 16:08
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
…ft#2135)

* Create ACI from command

* Add VSCode context for command visibility

* Don't show start/stop/restart
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants