Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for and flag outdated images #2073

Merged
merged 14 commits into from
Jul 8, 2020
Merged

Check for and flag outdated images #2073

merged 14 commits into from
Jul 8, 2020

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Jun 17, 2020

Fixes #1493. Looks like this:
image

@bwateratmsft bwateratmsft requested a review from a team as a code owner June 17, 2020 13:35
@bwateratmsft
Copy link
Collaborator Author

bwateratmsft commented Jun 17, 2020

@BigMorty:

Couple questions for you that @karolz-ms and I were discussing.

  1. There's two ways to decide if an image is out-of-date:
    1. If it's anything other than the latest image for this tag (i.e. compare their IDs), it's out-of-date.
    2. If it's more than X amount of time older than the latest image for this tag, it's out-of-date. If we want to do this instead, what is X?
  2. Refreshing--should a manual refresh trigger a new outdated check or is once per session good enough? Alternatively, should we offer a command to trigger a new outdated check?
    1. NOTE: if you pull a new version of an image, it will automatically no longer show as "out of date"--so an outdated check is not needed just to make the yellow icon go away on an image that is now up-to-date.
  3. On or off by default?

@BigMorty
Copy link
Member

  1. ImageID
  2. Start with once per session and see the feedback
  3. On by default, can always turn this off if we get feedback

package.json Outdated Show resolved Hide resolved
@karolz-ms
Copy link
Contributor

@bwateratmsft is this ready for review?

@bwateratmsft
Copy link
Collaborator Author

@bwateratmsft is this ready for review?

@karolz-ms Yes, I think so

package.nls.json Outdated Show resolved Hide resolved
@bwateratmsft bwateratmsft merged commit 835fe4a into master Jul 8, 2020
@bwateratmsft bwateratmsft deleted the bmw/outdated branch July 8, 2020 15:18
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark outdated images
3 participants