Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress during context switch #1969

Merged
merged 5 commits into from
May 13, 2020
Merged

Show progress during context switch #1969

merged 5 commits into from
May 13, 2020

Conversation

ravipal
Copy link
Contributor

@ravipal ravipal commented May 12, 2020

  1. Show the loading icon next to the context being switched
    image
  2. New auto refresh will be blocked while context switch is in progress.

Fixes #1965

@ravipal ravipal requested review from karolz-ms and bwateratmsft May 12, 2020 22:44
@ravipal ravipal requested a review from a team as a code owner May 12, 2020 22:44
src/tree/contexts/ContextTreeItem.ts Outdated Show resolved Hide resolved
src/extensionVariables.ts Outdated Show resolved Hide resolved
src/tree/contexts/ContextTreeItem.ts Outdated Show resolved Hide resolved
src/tree/LocalRootTreeItemBase.ts Outdated Show resolved Hide resolved
Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing the feedback!

src/tree/contexts/ContextTreeItem.ts Outdated Show resolved Hide resolved
src/tree/LocalRootTreeItemBase.ts Show resolved Hide resolved
@ravipal ravipal merged commit aefe5ac into master May 13, 2020
@ravipal ravipal deleted the ravipal/contextSwitch branch May 13, 2020 23:22
ravipal added a commit that referenced this pull request May 14, 2020
* Show progress during context switch

* Address review feedback

* move the cache clearing logic to useDockerContext

* Apply suggestions from code review

Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>

* remove unnecessary await

Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>
ravipal added a commit that referenced this pull request May 14, 2020
* Show progress during context switch

* Address review feedback

* move the cache clearing logic to useDockerContext

* Apply suggestions from code review

Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>

* remove unnecessary await

Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>

Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
* Show progress during context switch

* Address review feedback

* move the cache clearing logic to useDockerContext

* Apply suggestions from code review

Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>

* remove unnecessary await

Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When doing Context > Use in explorer view, takes 20s for "Connected" icon to move
4 participants