-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show progress during context switch #1969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolz-ms
requested changes
May 13, 2020
Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>
karolz-ms
approved these changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for addressing the feedback!
ravipal
added a commit
that referenced
this pull request
May 14, 2020
* Show progress during context switch * Address review feedback * move the cache clearing logic to useDockerContext * Apply suggestions from code review Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * remove unnecessary await Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>
ravipal
added a commit
that referenced
this pull request
May 14, 2020
* Show progress during context switch * Address review feedback * move the cache clearing logic to useDockerContext * Apply suggestions from code review Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * remove unnecessary await Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>
Dmarch28
pushed a commit
to Dmarch28/vscode-docker
that referenced
this pull request
Mar 4, 2021
* Show progress during context switch * Address review feedback * move the cache clearing logic to useDockerContext * Apply suggestions from code review Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * remove unnecessary await Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1965