.Net Core Attach support for windows container #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolz-ms
approved these changes
May 7, 2020
bwateratmsft
requested changes
May 7, 2020
bwateratmsft
reviewed
May 7, 2020
bwateratmsft
approved these changes
May 15, 2020
Dmarch28
pushed a commit
to Dmarch28/vscode-docker
that referenced
this pull request
Mar 4, 2021
* Attach support for windows container * update message * fix typo * Use dockerode to get inspect info * use docker os instead of contaier os
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we were not handling the windows container during attach. Now added support. But
docker cpcommand is not supported on hyper-v containers, which is the default in windows 10. So still this doesn't address most of the windows container. At least now this will provide a better error message.Fixes: #1662