Add an async lazy class and lazy lifetimes #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolz-ms
requested changes
Apr 14, 2020
ravipal
suggested changes
Apr 14, 2020
karolz-ms
approved these changes
Apr 15, 2020
ravipal
reviewed
Apr 15, 2020
ravipal
approved these changes
Apr 15, 2020
Dmarch28
pushed a commit
to Dmarch28/vscode-docker
that referenced
this pull request
Mar 4, 2021
* Add an async lazy class and lazy lifetimes * Add unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Not for 1.1)
Adds an
AsyncLazyclass that is smart enough to not re-run the task if it's currently running. Also adds lifetimes to forceLazys to re-evaluate, if the caller so specifies.One scenario where this would be useful is in places where we know we are going to query something several times in rapid succession--maybe
docker info, as an example--and we expect no changes to occur in some time span (e.g. 1 second), but want to share the result across each of these queries to avoid re-running code unnecessarily.