Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to run with a low-rights user in Python #1811

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Add logic to run with a low-rights user in Python #1811

merged 3 commits into from
Apr 3, 2020

Conversation

haniamr
Copy link
Contributor

@haniamr haniamr commented Apr 2, 2020 •
edited
Loading

  • If there isn't any chosen port that is less than 1024, then scaffold the logic to run as a low-rights user
  • Else, show a warning at the top that this will be running as root

Related to #1766

@haniamr haniamr requested a review from bwateratmsft April 2, 2020 00:37
@haniamr haniamr requested a review from a team as a code owner April 2, 2020 00:37
@haniamr haniamr linked an issue Apr 2, 2020 that may be closed by this pull request
The Dockerfiles created by the extension are insecure #1766
Closed
@haniamr haniamr added this to the 1.1.0 milestone Apr 2, 2020
@haniamr haniamr removed a link to an issue Apr 3, 2020
The Dockerfiles created by the extension are insecure #1766
Closed
@haniamr haniamr merged commit cc77f07 into master Apr 3, 2020
@haniamr haniamr deleted the hani/user-python branch April 3, 2020 17:39
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
@Dmarch28
Add logic to run with a low-rights user in Python (microsoft#1811)
d177255 
* Add logic to run with a low-rights user in Python

* PR feedback

* Change wording and short link
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ucheNkadiCode ucheNkadiCode ucheNkadiCode left review comments

@bwateratmsft bwateratmsft bwateratmsft approved these changes

@karolz-ms karolz-ms Awaiting requested review from karolz-ms

@philliphoff philliphoff Awaiting requested review from philliphoff

@ravipal ravipal Awaiting requested review from ravipal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haniamr @karolz-ms @ucheNkadiCode @bwateratmsft