Create Attach config for dotnet core compose #1652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| netCore: { | ||
| appProject: unresolveWorkspaceFolder(options.appProject, context.folder) | ||
| } | ||
| let debugConfigurations : DockerDebugConfiguration[] = [{ |
There was a problem hiding this comment.
I would if/else this. The .NET Core launch config probably not work in the expected way if a compose file is present (i.e. it will not use compose at all, users might be confused by this). Also, if compose I would also not add the docker-build / docker-run tasks.
There was a problem hiding this comment.
I don't get it. Why would single not work if compose file is present?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compose is selected during scaffolding, the 'Docker .NET Core Attach (Preview)' debug config is added automatically.
fixes #1543