Enable configuration for View Logs command #1554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Adds two configuration options, Follow and Tail, that match -f and --tail command line arguments of "docker logs" command. Closes microsoft#1505.
luka-zitnik
force-pushed
the
config-view-logs
branch
from
db60189 to
36d3b12
Compare
|
@luka-zitnik Thanks for the PR! As an update, we're going to have some discussions in the near future about how to more broadly allow for (consistent) customization of the various Docker commands performed by the extension (rather than have totally different solutions for each log vs. run vs. build vs attach command). Hence, it may take a bit before we can get this PR integrated and/or we may suggest some changes to align with the outcome of those discussions. |
|
@philliphoff OK. I'd love to see what you came up with. |
|
@luka-zitnik This will be addressed with #1649, do you want to close this PR? |
|
Yup |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two configuration options, Follow and Tail, that match -f and --tail command line arguments of "docker logs" command.
Closes #1505.