Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SSH remote Docker daemons #1386

Merged
merged 12 commits into from
Nov 5, 2019
Merged

Add support for SSH remote Docker daemons #1386

merged 12 commits into from
Nov 5, 2019

Conversation

bwateratmsft
Copy link
Collaborator

Resolves #646

@bwateratmsft bwateratmsft added this to the 0.9.0 milestone Nov 1, 2019
@bwateratmsft bwateratmsft requested a review from a team as a code owner November 1, 2019 14:50
bwateratmsft
bwateratmsft commented Nov 1, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
philliphoff
philliphoff reviewed Nov 1, 2019
View reviewed changes
src/utils/exec.ts Outdated Show resolved Hide resolved
philliphoff
philliphoff reviewed Nov 1, 2019
View reviewed changes
src/utils/exec.ts Outdated Show resolved Hide resolved
karolz-ms
karolz-ms requested changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestions, LGTM overall

src/utils/execAsync.ts Show resolved Hide resolved
src/utils/refreshDockerode.ts Show resolved Hide resolved
src/utils/refreshDockerode.ts Outdated Show resolved Hide resolved
@bwateratmsft bwateratmsft merged commit b58b338 into master Nov 5, 2019
@bwateratmsft bwateratmsft deleted the bmw/ssh branch November 5, 2019 13:58
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karolz-ms karolz-ms karolz-ms approved these changes

@philliphoff philliphoff philliphoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Add support for ssh
3 participants
@bwateratmsft @philliphoff @karolz-ms