Add a command to create the simplest network #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philliphoff
reviewed
Oct 18, 2019
bwateratmsft
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Looks good to me. I'll let @stuartthomson and @philliphoff decide on the name validation. showInputBox allows for InputBoxOptions which in turn can have a validation method; a regex would make that very simple to do.
philliphoff
approved these changes
Oct 22, 2019
|
Resolves #1322 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was requested in #1322.
I could not find an appropriate icon for this action in the resources directory so I'm not sure that it can be merged until one is added.