Change extension to run in remote workspace by default #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
commented
Aug 28, 2019
| ]; | ||
|
|
||
| if (isLinux()) { | ||
| result.push(new OpenUrlTreeItem(this, 'Manage Docker as a non-root user on Linux...', linuxPostInstallUrl)) |
There was a problem hiding this comment.
Removed this per discussion with Matt since it's already in the troubleshooting link and 4 links (in the dev container case) seemed excessive
| } else { // otherwise update the global setting | ||
| target = ConfigurationTarget.Global; | ||
| if (typeof values.globalValue === 'object' && values.globalValue !== null) { | ||
| value = values.globalValue || {}; |
There was a problem hiding this comment.
nit: The ||{} is just defensive, right? If it's an object and not null, then can it be falsy?
There was a problem hiding this comment.
You're right - shouldn't be possible to be falsy
StephenWeatherford
approved these changes
Sep 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #954. See that issue for more info on why we want to default to workspace extension instead of ui extension.
In addition to changing the default (which is the most important change), I added some helpful error messages to common scenarios.
Scenario 1
User has Docker installed as "ui" extension. Currently they will see a bunch of random errors for unsupported actions like this:
I added this error message instead:
Scenario 2
User has Docker installed as "workspace" extension in dev container. "Add Docker Files to Workspace" should work, but any commands using the terminal won't work and the explorer won't show anything.
All I did was add a link in the explorer. The docs still need to be written, but we will likely direct them to one of these options:
In terms of commands that require a terminal - I still think the long term fix is to move those over to Dockerode anyways.