Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker new .netcore issues #264

Closed
RonakThakkar opened this issue May 19, 2018 · 1 comment
Closed

docker new .netcore issues #264

RonakThakkar opened this issue May 19, 2018 · 1 comment

Comments

@RonakThakkar
Copy link

There are several issues.

  1. docker new .netcore uses old asp.net core image FROM microsoft/aspnetcore:1. It should use new image as FROM microsoft/aspnetcore:2.0

  2. dockerfile should be created using multi stage as shown in below link
    https://docs.docker.com/engine/examples/dotnetcore/#create-a-dockerfile-for-an-aspnet-core-application

  3. dockerfile should have different content and base image for .NET Core Console and .NET Core ASP.NET Web API. Right not it creates same for both types of projects.

@chrisdias
Copy link
Member

I've got a request out to the .NET folks for updated dockerfile artifacts...

chrisdias added a commit that referenced this issue May 23, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants