Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dialog "Do you want to copy the debugger to the container" still pops up for the second debugging #2186

Closed
v-ruizh opened this issue Jul 23, 2020 · 4 comments
Assignees
Milestone

Comments

@v-ruizh
Copy link

v-ruizh commented Jul 23, 2020

OS: Win 10/Mac
Build Version: 20200722.19

Repro Steps:

  1. Create a .NET Core mvc app by "dotnet new mvc --name mvctest".
  2. Open the project in VS Code --> Prompt to add the required assets --> Yes
  3. F1 --> Type and select "Docker: Add Docker Files to Workspace" --> ASP.NET Core --> Linux --> Include optional Docker Compose files.
  4. Right click the docker-compose.yml --> Select "Compose Up".
  5. Open launch.json and click 'Add Configration…', and choose 'Docker .NET Core Attach (Preview)'.
  6. Run the above configuration, select the running container from step4 and click yes to copy debugging to the container.
  7. Disconnect this attach, then F5 and connect to the same container.

Expect:
There shouldn't be any prompt to copy debugger.

Actual:
The dialog "Do you want to copy the debugger to the container" still pops up.
image

More Info:
This issue does not reproduce on the latest released Docker extension build.

@karolz-ms
Copy link
Contributor

I am actually not able to complete step 6 successfully ☹️ I am getting the following error instead (starting the debugger inside the container fails):

Starting: "docker" exec -i mvctest_mvctest_1 /remote_debugger/vsdbg --interpreter=vscode
OCI runtime exec failed: exec failed: container_linux.go:349: starting container process caused "no such file or directory": unknown

Note I am running Docker Edge 2.3.3.2 build 46784

@karolz-ms
Copy link
Contributor

Seems like the vsdbg scripts are incorrectly encoded (CR-LF vs LF)...

@karolz-ms
Copy link
Contributor

OK the problem above turned out a line ending mismatch that git did not detect. Needed to delete the file and do git checkout --force on the path to have it updated. 🙄 Back to the bug...

karolz-ms added a commit that referenced this issue Jul 31, 2020
Fixes issue 2186 #2186

Also adds a bit more information about debugger copying to the output
@karolz-ms
Copy link
Contributor

Fixed by 0645b1c

Thanks for reporting @v-ruizh !

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants